fix: set the remaining extra fields for inputsShema #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
mathetake
reviewed
Nov 7, 2025
hustxiayang
force-pushed
the
fix-anthropic-function-nested-schema
branch
from
c8fb831 to
29cb1bb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
==========================================
- Coverage 83.26% 83.24% -0.03%
==========================================
Files 137 137
Lines 12059 12060 +1
==========================================
- Hits 10041 10039 -2
- Misses 1411 1413 +2
- Partials 607 608 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
looks good to me! deferring to @yuzisun |
dosubot
bot
added
size:L
Contributor
Author
|
@mathetake thanks for your free golang tutorial! |
hustxiayang
changed the title
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
hustxiayang
force-pushed
the
fix-anthropic-function-nested-schema
branch
from
1fc25d1 to
8960a50
Compare
Contributor
Author
|
/retest |
Member
|
@yuzisun good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the original codes, it drops every thing other than
properties. Thus, other data likedefsare dropped. it should be stored into extra filelds.